Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit testing infrastructure, including pytest configuration, code coverage tracking, linting with ruff and mypy, and CI/CD workflows via GitHub Actions. The changes include new test files for various components, test fixtures (JSON files), code refactoring to improve testability, and automation scripts.
Changes:
- Added unit tests for frontend operators, utilities, and configuration classes
- Configured pytest with coverage tracking and test discovery options
- Integrated ruff and mypy for code quality and type checking
- Set up GitHub Actions workflows for automated testing and linting
Reviewed changes
Copilot reviewed 105 out of 119 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added dev dependencies (pytest-cov, ruff, mypy) and tool configurations |
| neusim/npusim/frontend/tests/test_operator.py | New unit tests for Operator classes and CSV serialization |
| neusim/npusim/frontend/tests/test_frontend_util.py | New tests for frontend utility functions |
| neusim/npusim/frontend/tests/assets/raw/* | Test fixture JSON files for various models |
| neusim/npusim/backend/util.py | Moved parse_input/output_tensor_shapes functions here |
| neusim/npusim/backend/tests/test_util.py | Deleted old test file |
| neusim/npusim/backend/npusim_lib.py | Updated to use moved utility functions |
| neusim/configs/tests/* | New unit tests for configuration classes |
| neusim/configs/models/LLMConfig.py | Fixed default value handling bug |
| lint.sh | New shell script for running linting checks |
| .github/workflows/*.yml | GitHub Actions workflows for CI/CD |
| README.md | Added CI status badges |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests (pytest), coverage test, python language linting, and CI workflow.