Fix --file/--body aliasing in pc vector upsert#64
Merged
austin-denoble merged 3 commits intomainfrom Feb 10, 2026
Merged
Conversation
…t since --body is an alias, add custom validation / error handling for the empty file/body case
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@bradumbaugh reported an issue with the aliasing in the
pc vector upsertcommand.--fileand--bodyflags are meant to be aliases, but--fileis configured as required making--bodyunusable due to cobra error'ing when--fileis not passed.Solution
Make sure --file is not configured as a required flag to vector upsert since --body is an alias, add custom validation / error handling for the empty file/body case.
Additionally, I cleaned up a
.cachefolder that was incorrectly committed to source previously, along with removing the claude-code-review workflows from the repo. We've been using cursorbot generally, and I'll get this repo setup with that in a follow-up PR.Before
###After
Type of Change
Test Plan
Test corrected flow by calling
pc index vector upsert --index-name my-index --body my-file.jsonand observe no errors.