Open
Conversation
Contributor
Author
|
Looks like |
dunglas
approved these changes
Feb 15, 2026
alexandre-daubois
approved these changes
Feb 15, 2026
henderkes
approved these changes
Feb 16, 2026
45cbd50 to
fec70c5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR automatically enables ignore_user_abort for worker threads, eliminating the need for users to manually configure this setting via INI or in their worker scripts.
Changes:
- Automatically sets
ignore_user_abortto true for worker threads and restores the original setting for non-worker threads - Adds a test to verify workers continue execution after connection abort
- Removes documentation instructing users to manually call
ignore_user_abort(true)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frankenphp.c | Stores original ignore_user_abort setting and automatically enables it for worker threads |
| worker_test.go | Adds test case verifying worker continues after client connection abort |
| docs/worker.md | Removes manual ignore_user_abort(true) call from documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fec70c5 to
3a17d41
Compare
…glas/frankenphp into fix/always-ignore-user-abort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically sets
ignore_user_abortto true in worker mode as mentioned in #2186, removing the requirement to change it via ini.Would also be possible to expose something like an explicit
frankenphp_client_has_closed()function for in-between critical sections.