Skip to content

Remove calls to curl_close and curl_multi_close on PHP 8.0 and later #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vitorinox merged 1 commit into from
Feb 17, 2026
Merged

Remove calls to curl_close and curl_multi_close on PHP 8.0 and later #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Http/CurlDispatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ public static function fetch(array $settings, ResponseFactoryInterface $response
curl_multi_remove_handle($multi, $curlHandle);
}

curl_multi_close($multi);
if (PHP_VERSION_ID < 80000) {
curl_multi_close($multi);
}

return array_map(
fn ($connection) => $connection->getResponse($responseFactory),
Expand Down Expand Up @@ -160,8 +162,10 @@ private function getResponse(ResponseFactoryInterface $responseFactory): Respons
$this->error(curl_error($curlHandle), $errno);
}

/** @phpstan-ignore argument.type (PHP 7.4/8.0 compatibility) */
curl_close($curlHandle);
if (PHP_VERSION_ID < 80000) {
/** @phpstan-ignore argument.type (PHP 7.4/8.0 compatibility) */
curl_close($curlHandle);
}

$response = $responseFactory->createResponse($info['http_code']);

Expand Down