fix: reserved keyword not quoted in online rewrite DDL (#286)

[tianzhou]

Summary

• The getTableNameWithSchema helper in internal/plan/rewrite.go was returning raw table/schema names without calling ir.QuoteIdentifier(), causing reserved keywords like order to produce invalid SQL in online rewrite operations (CREATE INDEX CONCURRENTLY, constraint rewrites, FK rewrites, NOT NULL rewrites, identity column rewrites)
• The equivalent function in internal/diff/diff.go already quoted correctly, so only the plan rewrite path was affected

Fixes #286

Test plan

• Added testdata/diff/online/issue_286_reserved_keyword_quoting/ test case with a table named order (reserved keyword) that gets a new column with FK and an index
• Diff test passes: PGSCHEMA_TEST_FILTER="online/issue_286_reserved_keyword_quoting" go test -v ./internal/diff -run TestDiffFromFiles
• Plan test passes (including apply verification): PGSCHEMA_TEST_FILTER="online/issue_286_reserved_keyword_quoting" go test -v ./cmd -run TestPlanAndApply
• All online tests pass: PGSCHEMA_TEST_FILTER="online/" go test -v ./cmd -run TestPlanAndApply
• Full test suite passes (no regressions)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes a bug where reserved keyword table names (like order) were not being properly quoted in online rewrite DDL operations such as CREATE INDEX CONCURRENTLY, foreign key rewrites, constraint rewrites, NOT NULL rewrites, and identity column rewrites. The fix ensures that getTableNameWithSchema in internal/plan/rewrite.go properly quotes identifiers using ir.QuoteIdentifier(), matching the behavior already implemented in internal/diff/diff.go.

Changes:

• Modified getTableNameWithSchema helper function to quote table and schema names using ir.QuoteIdentifier()
• Added comprehensive test case with a table named order (a reserved keyword) to verify the fix

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/plan/rewrite.go	Fixed getTableNameWithSchema to quote table and schema identifiers, preventing SQL syntax errors with reserved keywords
testdata/diff/online/issue_286_reserved_keyword_quoting/old.sql	Test setup: defines a table named order (reserved keyword) with basic columns
testdata/diff/online/issue_286_reserved_keyword_quoting/new.sql	Test setup: adds a column with FK constraint and index to the order table
testdata/diff/online/issue_286_reserved_keyword_quoting/plan.txt	Expected output: verifies table name is quoted in all DDL statements
testdata/diff/online/issue_286_reserved_keyword_quoting/plan.sql	Expected output: verifies table name is quoted in SQL plan
testdata/diff/online/issue_286_reserved_keyword_quoting/plan.json	Expected output: verifies table name is quoted in JSON plan
testdata/diff/online/issue_286_reserved_keyword_quoting/diff.sql	Expected output: verifies table name is quoted in diff SQL

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.