Fixed an issue where AI features are visible in the UI even when LLM_…#9727
Merged
akshay-joshi merged 2 commits intopgadmin-org:masterfrom Mar 16, 2026
Merged
Conversation
…ENABLED is set to False
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughPasses the backend LLM_ENABLED flag to the frontend and uses it to conditionally register AI preferences, menus, and the AI Assistant tab; initialization and menu registration are gated on the system-level LLM status. Changes
Sequence Diagram(s)sequenceDiagram
participant Config as System Config
participant PyInit as Python: browser/__init__.py
participant JSUtils as JavaScript: utils.js
participant LLMModule as Python: llm/__init__.py
participant AITools as JavaScript: ai_tools.js
participant QueryTool as JS: QueryToolComponent
Config->>PyInit: read LLM_ENABLED
PyInit->>JSUtils: render template with llm_enabled
JSUtils->>JSUtils: set pgAdmin.llm_enabled
alt System LLM disabled
LLMModule->>LLMModule: skip register_preferences()
AITools->>AITools: skip registerMenus() / defer registration
QueryTool->>QueryTool: omit AI Assistant tab
else System LLM enabled
LLMModule->>LLMModule: register_preferences()
AITools->>AITools: call registerMenus()
QueryTool->>QueryTool: include AI Assistant tab
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
The test failure here is the flakey test fixed in #9723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ENABLED is set to False. Fixes #9709
Summary by CodeRabbit
Bug Fixes
Improvements