script: fix witness_version() to decode small int opcodes#314
Open
EricGrill wants to merge 1 commit intopetertodd:masterfrom
Open
script: fix witness_version() to decode small int opcodes#314EricGrill wants to merge 1 commit intopetertodd:masterfrom
EricGrill wants to merge 1 commit intopetertodd:masterfrom
Conversation
The witness_version() method was returning the raw opcode value instead of the decoded integer. For witness version 0 (OP_0 = 0x00) this worked by coincidence, but for witness version 1 (OP_1 = 0x51) it incorrectly returned 0x51 instead of 1. Fix by calling decode_op_n() to properly convert the small int opcode to its integer value. Closes petertodd#298 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
CScript.witness_version()to properly return witness version integers.Problem
The method was returning the raw opcode value instead of the decoded integer:
Solution
Call
decode_op_n()on the opcode to convert small integer opcodes to their values.Closes #298
🤖 Generated with Claude Code