Conversation
Member
|
This branch doesn't merge and also doesn't build, due to outdated requirements. |
Contributor
Author
|
I've fixed the conflicts, but we should probably decide on whether this new behaviour is actually an improvement, and if you think it is, it might be worth playing around with it more to iron out any corner-case issues there might be. |
Member
|
This is why I tried getting it to deploy! |
1f51521 to
9634809
Compare
9634809 to
54a2f30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, the sidebar manages which elements are automatically focussed when switching to a new pane inside the IDE. Specifically:
The following gif demonstrates the new behaviour.
These changes make it much easier to navigate CloudPebble exclusively with the keyboard in that it's an improvement on the current state of tab-focus (when you switch to a new page and then click TAB, you focus on the navigation), but I'm not 100% sure that it's the best solution. Specifically, it might be better to just autofocus on the first form element every time, and not remember the previously focussed element.