Use cmake to build libui, rename link target ui -> libui.#14
Open
zentner-kyle wants to merge 1 commit intopcwalton:masterfrom
Open
Use cmake to build libui, rename link target ui -> libui.#14zentner-kyle wants to merge 1 commit intopcwalton:masterfrom
zentner-kyle wants to merge 1 commit intopcwalton:masterfrom
Conversation
|
I'm on windows, and this is exactly what I needed to get it working. Comment about this PR: I did have to manually go in and build libui in visual studio for release configuration for this to work correctly. It was only building debug, but my linker was expecting the libui.lib binary to be in /out/release folder. Not sure if that is a bug, or if something I'm doing wrong. Thanks for the fix though 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates libui to the latest version in upstream, with a commit from me to make MSVC builds work in release mode.
I've tested that the examples still build under MSVC, Linux, and OSX.
Unfortunately, the examples nearly instantly crash on OSX.