Fix row alignment when column selection heuristic excludes distinguishing columns#217
Open
jamesscottbrown wants to merge 1 commit intopaulfitz:masterfrom
Open
Fix row alignment when column selection heuristic excludes distinguishing columns#217jamesscottbrown wants to merge 1 commit intopaulfitz:masterfrom
jamesscottbrown wants to merge 1 commit intopaulfitz:masterfrom
Conversation
…hing columns Co-authored-by: Shelley <shelley@exe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a table has more than 5 columns, daff falls back on heuristics. These can fail, causing daff to incorrectly report that a row was deleted and another inserted, rather than reporting that a row was modified. This is Issue #216.
The PR is a proposed fix, created by an LLM (claude-opus-4.5). It looks plausible to me and the tests pass, but I am unfamiliar with the Haxe language and table-comparison logic is somewhat complex.
It adds a fallback matching mechanism in
coopy/CompareTable.hxthat: