Skip to content

add deployment history page#151

Open
argha-dot wants to merge 2 commits intodevelopfrom
feat/deployment-history
Open

add deployment history page#151
argha-dot wants to merge 2 commits intodevelopfrom
feat/deployment-history

Conversation

@argha-dot
Copy link
Collaborator

Re: #135, cause that branch had merge conflicts

@argha-dot
Copy link
Collaborator Author

@rakshith-ravi can you merge this and close #135?

<td class="flex-2">
<span class="truncate">{deploy.imageDigest}</span>
</td>
<td class="flex-1">{deploy.created.toLocaleString().split(".")[0]}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use relative time

<Show when={deploymentHistory()} fallback={<div>Loading deployment history...</div>}>
<Table
column_grids={["flex-2", "flex-1"]}
headings={["Event", "Log Date"]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a better name for this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better name for what?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the headings

<span class="truncate">{deploy.imageDigest}</span>
</td>
<td class="flex-1">{deploy.created.toLocaleString().split(".")[0]}</td>
</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a "revert to this version" button

@argha-dot
Copy link
Collaborator Author

@Sanket-Singhvi can you take up the issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants