-
-
Notifications
You must be signed in to change notification settings - Fork 159
fix: convert int and double to string in otel body #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: convert int and double to string in otel body #1544
Conversation
WalkthroughChanges to OpenTelemetry value serialization in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/otel/otel_utils.rs`:
- Around line 82-85: The IntValue arm in the conversion logic
(OtelValue::IntValue) is incorrectly pushing both a string and a numeric
serde_json::Number into json_array, producing duplicate entries; update the
OtelValue::IntValue handling so it only pushes the string representation
(Value::String(i.to_string())) to json_array to match the top-level IntValue
behavior and DoubleValue handling, leaving the rest of the function unchanged
and removing the serde_json::Number::from(*i) push.
Summary by CodeRabbit