Skip to content

Add svgToPdf.js plug-in and note about GPL Lesser 3.0#264

Closed
brettz9 wants to merge 1 commit intoparallax:masterfrom
brettz9:svgToPdf
Closed

Add svgToPdf.js plug-in and note about GPL Lesser 3.0#264
brettz9 wants to merge 1 commit intoparallax:masterfrom
brettz9:svgToPdf

Conversation

@brettz9
Copy link
Contributor

@brettz9 brettz9 commented May 22, 2014

Since it is a plug-in, I thought you may be open to just accepting the plug-in code as is.

@diegocr
Copy link
Contributor

diegocr commented May 25, 2014

Brettz, you can't just throw some "plugin" code into our tree and expect it to work OOTB on jsPDF, at least i can't see there our initialization code (see the template file)

@brettz9
Copy link
Contributor Author

brettz9 commented May 25, 2014

It does work, but sorry, I do see it is not following your API for plug-ins. (One passes in one's own jsPDF object to svgElementToPdf().) I can rework it.

@diegocr
Copy link
Contributor

diegocr commented May 25, 2014

I see. In fact without using our API it'd get removed from the production file as unused by our build script.

In any case, i did a bit of research and found a newer file here: https://github.com/CBiX/svgToPdf.js

So, we can just add that as a submodule, assuming that's fine to @cbix

Also, they have a PR adding it as a full-compliant jsPDF plugin (and replacement for our current sillysvgrenderer), which i guess will be merged as soon is made backward-compatible. I will also love if the jQuery dependency is removed.

Perhaps you would like to consider working with them on fixing that on their side.

@diegocr diegocr closed this May 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants