Conversation
✅ Deploy Preview for rubycon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @a-chris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the visual presentation of the conference agenda, particularly for mobile users. It achieves this by reformatting the Ruby DSL used to define agenda items for improved clarity and by implementing responsive font size adjustments for code blocks, ensuring a more readable and aesthetically pleasing experience across various screen sizes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to improve the agenda layout, particularly for mobile devices. While the CSS adjustments seem appropriate for this goal, there are critical issues in the Ruby DSL file (rubycon.it/_includes/dsl/content.rb) that will cause the application to crash. Specifically, the code calls a non-existent class and method for the schedule, and the party event is called with an undefined keyword argument. Additionally, this pull request does not adhere to the repository's contribution guidelines, which require updating CHANGELOG.md and incrementing the site_version in _config.yml with every change (lines 50 and 78 of the repository style guide). Please address these critical issues and the process violation.
|
|
||
| pause at: "13:00", desc: "🍝 Lunch Break & Networking" | ||
|
|
||
| Rubycon::Agenda.schedule(Date.new(2026, 5, 8)) do |
There was a problem hiding this comment.
The class Rubycon::Agenda and its method schedule do not appear to be defined. According to _includes/dsl/definition.rb, the correct invocation should be Rubycon::Schedule.agenda_of_the_day. This error will cause a NameError and break the page.
Rubycon::Schedule.agenda_of_the_day(Date.new(2026, 5, 8)) do| party at: "20:00", | ||
| desc: "🍝 Dinner + 🎉 Toga Party!", | ||
| where: '🏖️ Bagno 46', | ||
| url: 'https://www.bagno46rimini.com/' |
There was a problem hiding this comment.
The party method is called with a url keyword argument, which is not defined in its signature in _includes/dsl/definition.rb. This will raise an ArgumentError: unknown keyword: :url and cause a crash. Please remove the url argument or update the method definition if it's intended to be supported.
party at: "20:00",
desc: "🍝 Dinner + 🎉 Toga Party!",
where: '🏖️ Bagno 46'| check_in at: "08:30", | ||
| desc: "Check-in & Welcome Coffee" |
There was a problem hiding this comment.
The indentation of the DSL method calls is inconsistent. This check_in call is not indented, while subsequent calls (e.g., talk on line 10) are. To improve code readability and maintain a consistent style, all top-level DSL calls within the block should have the same indentation.
check_in at: "08:30",
desc: "Check-in & Welcome Coffee"| lightning_talks at: "14:30", | ||
| desc: "⚡️ 5m for everyone who has something to say" , | ||
| tags: %w{ FIFO } |
There was a problem hiding this comment.
There is a trailing space before the comma on line 37, which is a minor style issue. Removing it will improve code consistency.
lightning_talks at: "14:30",
desc: "⚡️ 5m for everyone who has something to say",
tags: %w{ FIFO }1 participant
Improving agenda layout especially for mobile devices, I'm open to suggestions 🙌
Desktop:
Mobile:
