Prevent event bubbling on copy-to-clipboard clicks#2893
Merged
charliepark merged 2 commits intomainfrom Aug 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
approved these changes
Aug 25, 2025
Collaborator
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks good. Might not need the e.preventDefault(): since it's not a submit button, I don't think there is a default behavior.
Contributor
Author
|
Yeah, debated leaving that out, but read that it's often included on event handlers alongside stopPropagation by convention, but that felt a little funny to me as well. Will drop it out and we can add it down the road if it's ever needed. It won't be. |
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #2860, I noticed that clicking the copy buttons was opening the JSON viewer for each row, because the CopyToClipboard component isn't capturing the event bubbling. This fixes that.