Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…mputer/console into tls-cert-soft-validation
|
Added tests, improved wildcard handling and also a message in case the certificate cannot be parsed. 
Message copy needs work. |
|
Do we have a good way of getting the domain? I vaguely remember some discussion around with the IdP setup. |
|
This looks awesome, thanks for picking it up. I think initial rack install will certainly benefit from it. |
Do we need some copy to caveat incase that is not correct. I remember some talk about a proxy perhaps throwing it off? |
| const { data: certValidation } = useQuery({ | ||
| queryKey: ['validateImage', ...(file ? [file.name, file.size, file.lastModified] : [])], | ||
| queryFn: file ? () => file.text().then(parseCertificate) : skipToken, | ||
| }) |
There was a problem hiding this comment.
@charliepark pointed out we might want to set the stale time directly here. I'm going to experiment with that and also maybe tweaking the query key.
4 participants
Fixes #2580 and related to #2578
Idea from @augustuswm to soft validate the cert. Unfortunately I think we need a library to parse the cert but I lazy imported it to avoid adding to the main bundle since most users will not see this.
Principally the risk here is what I dont know about certs:
parseCertificate()doesn't catchBut feels, like the image soft validation, that it could be a good quality of life improvement for something that is potentially very painful when not done correctly. We might want to label the
CNandSANon the messages list of found names.