fix: enable LeaderElectionReleaseOnCancel for rolling updates#64
Open
ermakov-oleg wants to merge 1 commit intooperasoftware:mainfrom
Open
fix: enable LeaderElectionReleaseOnCancel for rolling updates#64ermakov-oleg wants to merge 1 commit intooperasoftware:mainfrom
ermakov-oleg wants to merge 1 commit intooperasoftware:mainfrom
Conversation
ermakov-oleg
force-pushed
the
fix/leader-election-release
branch
from
50b0bcb to
2160c8b
Compare
Port of upstream PR cloudnative-pg#615. Without this flag, RollingUpdate causes deadlock — old pod holds leader lease preventing new pod from becoming ready. Signed-off-by: ermakov-oleg <ermakovolegs@gmail.com>
ermakov-oleg
force-pushed
the
fix/leader-election-release
branch
from
2160c8b to
bca739d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of upstream #615
Enables
LeaderElectionReleaseOnCancel: truein the controller manager options.Problem: During rolling updates of the operator deployment, the old pod holds the leader election lease until it expires (default 15s). This means the new pod cannot start reconciliation until the lease times out, causing a gap in controller activity.
Fix: Setting
LeaderElectionReleaseOnCancel: truemakes the old leader release the lease immediately on context cancellation (graceful shutdown), so the new pod can acquire leadership instantly.