Skip to content

Comments

fix reporting by using correct var in log_result#837

Open
oliver-smakal wants to merge 1 commit intoopenshift:masterfrom
oliver-smakal:netobserv_fix_reporting
Open

fix reporting by using correct var in log_result#837
oliver-smakal wants to merge 1 commit intoopenshift:masterfrom
oliver-smakal:netobserv_fix_reporting

Conversation

@oliver-smakal
Copy link

This is a fix for the missreporting of the check_netobserv_pods and check_flowcollector functions.

This was the result before in the final report:

[Function]               |     Total|    Passed|    Failed|Failure Rate|
-----------------------------------------------------------------------
[check_netobserv_pods]   |      1500|         0|      1500|    100.0%|
[check_flowcollector]    |      1500|         0|      1500|    100.0%|

even though it was clear all of the runs were successful, after a short 10m runs I have verified that the fix works and reporting is now correct:

[Function]               |     Total|    Passed|    Failed|Failure Rate|
-----------------------------------------------------------------------
[apply_nonamespace]      |         5|         5|         0|      0.0%|
[check_netobserv_pods]   |         2|         2|         0|      0.0%|
[check_flowcollector]    |         2|         2|         0|      0.0%|
-----------------------------------------------------------------------

@openshift-ci openshift-ci bot requested review from liqcui and mffiedler February 18, 2026 15:02
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

@oliver-smakal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@oliver-smakal
Copy link
Author

/assign @kapjain-rh @memodi

@kapjain-rh
Copy link

/lgtm

Copy link
Contributor

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @oliver-smakal

/cc @qiliRedHat

@openshift-ci openshift-ci bot requested a review from qiliRedHat February 18, 2026 16:02
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: memodi, oliver-smakal
Once this PR has been reviewed and has the lgtm label, please assign liqcui for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants