Skip to content

SPLAT-2615: Added AWS dynamic dedicated host support#1455

Open
vr4manta wants to merge 4 commits intoopenshift:mainfrom
vr4manta:SPLAT-2615
Open

SPLAT-2615: Added AWS dynamic dedicated host support#1455
vr4manta wants to merge 4 commits intoopenshift:mainfrom
vr4manta:SPLAT-2615

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Jan 21, 2026

SPLAT-2615

Changes

  • Updated webhook to now handle new dynamic host fields
  • Vendor update to get new API changes

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2026

@vr4manta: This pull request references SPLAT-2615 which is a valid jira issue.

Details

In response to this:

SPLAT-2615

Changes

  • Updated webhook to now handle new dynamic host fields
  • Vendor update to get new API changes

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2026

@vr4manta: This pull request references SPLAT-2615 which is a valid jira issue.

Details

In response to this:

SPLAT-2615

Changes

  • Updated webhook to now handle new dynamic host fields
  • Vendor update to get new API changes

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta marked this pull request as ready for review February 16, 2026 15:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@vr4manta
Copy link
Contributor Author

/assign @damdo

@vr4manta
Copy link
Contributor Author

Adding some tests based on peer review

@vr4manta
Copy link
Contributor Author

/retest

@nrb
Copy link
Contributor

nrb commented Feb 19, 2026

/assign @nrb

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2026
@nrb
Copy link
Contributor

nrb commented Feb 23, 2026

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2026
@vr4manta
Copy link
Contributor Author

/label acknowledge-critical-fixes-only
/verified by @vr4manta manual testing
Verified via local testing and presubmits in conjunction w/ other PRs

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 23, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 23, 2026
@openshift-ci-robot
Copy link
Contributor

@vr4manta: This PR has been marked as verified by @vr4manta manual testing.

Details

In response to this:

/label acknowledge-critical-fixes-only
/verified by @vr4manta manual testing
Verified via local testing and presubmits in conjunction w/ other PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@JoelSpeed
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member

damdo commented Feb 24, 2026

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 f13d585 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor Author

The e2e-metal-ipi-ovn-ipv6 keeps failing for

: [sig-node] Pods Extended (pod generation) [Feature:PodObservedGenerationTracking] [FeatureGate:PodObservedGenerationTracking] [Beta] Pod Generation pod observedGeneration field set in pod conditions expand_less	34s
{  fail [k8s.io/kubernetes/test/e2e/node/pods.go:715]: Timed out after 30.000s.
expected condition PodReadyToStartContainers generation to be 2, got 1 instead:}

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@vr4manta: This PR was included in a payload test run from openshift/machine-api-provider-aws#174
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/af501260-11b1-11f1-8355-45eb72a0dd0e-0

@nrb
Copy link
Contributor

nrb commented Feb 24, 2026

Seeing this job fail on other PRs but for different reasons, so it's not related to these changes.

Looks like the failures are being tracked in https://issues.redhat.com/browse/OCPBUGS-76599

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@vr4manta: This PR was included in a payload test run from openshift/machine-api-provider-aws#174
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8fbbd240-11c0-11f1-9976-41485f7c73c3-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

@vr4manta: This PR was included in a payload test run from openshift/machine-api-provider-aws#174
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aee21670-1242-11f1-9543-785cee1a4298-0

@vr4manta
Copy link
Contributor Author

@JoelSpeed can we override this failing test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants