Eliminate expensive and unnecessary MachineConfig updates#1473
Eliminate expensive and unnecessary MachineConfig updates#1473jmencak wants to merge 1 commit intoopenshift:mainfrom
Conversation
GetMutatedMachineConfig() PPC function does not handle comparison between MachineConfigs well. The spec.Config.Raw field contains a raw JSON string, which first needs to be normalized prior to comparison. Otherwise, semantically identical but order-different raw json data will trigger unnecessary MachineConfig updates. This issue affects both regular OpenShift and HyperShift. This change resolves this issue by first normalizing the raw JSON strings in both MachineConfigs prior to comparison.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
GetMutatedMachineConfig() PPC function does not handle comparison between MachineConfigs well. The
spec.Config.Rawfield contains a raw JSON string, which first needs to be normalized prior to comparison. Otherwise, semantically identical but order-different raw json data will trigger unnecessary MachineConfig updates. This issue affects both regular OpenShift and HyperShift.This change resolves this issue by first normalizing the raw JSON strings in both MachineConfigs prior to comparison.