Migrate away from deprecated ioutil#102
Open
sebrandon1 wants to merge 1 commit intoopenshift-kni:mainfrom
Open
Migrate away from deprecated ioutil#102sebrandon1 wants to merge 1 commit intoopenshift-kni:mainfrom
sebrandon1 wants to merge 1 commit intoopenshift-kni:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ioutilhas been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutilTracking issue: redhat-best-practices-for-k8s/telco-bot#52
Migration from
ioutiltoos/ioand related refactoring:ioutil.ReadFile,ioutil.WriteFile, andioutil.ReadAllwithos.ReadFile,os.WriteFile, andio.ReadAllrespectively across all affected files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]ioutil.Discardtoio.Discardfor logger initialization and null logging. [1] [2] [3] [4]Directory reading and file info handling:
ioutil.ReadDirto useos.ReadDir, and reconstructed[]os.FileInfoslices by calling.Info()on each directory entry, ensuring compatibility with the new API. This impacts methods inpkg/fswrap/fswrap.goandpkg/machineinformer/relocatablesysfs.go. [1] [2] [3]Test and temporary file management updates:
ioutil.TempDirwithos.MkdirTempin test files for creating temporary directories, and updated test file writing to useos.WriteFile. [1] [2] [3] [4] [5] [6]General import cleanup:
ioutilimports and updated import blocks to useosandioas needed. [1] [2] [3] [4] [5] [6] [7] [8]These changes modernize the codebase and remove reliance on deprecated APIs, improving maintainability and future compatibility.