added stronger TLS ciphers default#6003
Draft
ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
Draft
added stronger TLS ciphers default#6003ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
ThyTran1402 wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
Signed-off-by: Thy Tran <58045538+ThyTran1402@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default TLS configuration allowed weak protocols (TLSv1.1) and cipher suites (CBC-mode, SHA-1 MAC, DHE_DSS, IBM SSL_-prefix) that are considered insecure by modern standards.
Default protocols:
["TLSv1.3", "TLSv1.2", "TLSv1.1"]Default ciphers: 37 entries including CBC-mode, SHA-1 MAC, DHE_DSS, and IBM
SSL_-prefix duplicates, based on Chrome 48 / Firefox 42 supportOutbound connectors defaulted to
["TLSv1.2", "TLSv1.1"]Explicitly configuring TLSv1/TLSv1.1 logged a deprecation warning
Default protocols:
["TLSv1.3", "TLSv1.2"](Mozilla Intermediate TLS profile)Default ciphers: 10 entries — TLS 1.3 suites + ECDHE+GCM + ECDHE+ChaCha20 for TLS 1.2 only
All outbound connectors share the same default protocol list via a new
SSLConfigConstants.DEFAULT_SSL_PROTOCOLSconstantExplicitly configuring TLSv1 or TLSv1.1 now causes a hard startup failure
Issues Resolved
#2157
Testing
SSLConfigConstantsTest: default protocol assertions updated to reflect removal of TLSv1.1SslParametersTestrequired no changes: existing assertions already expect["TLSv1.3", "TLSv1.2"]since the JDK intersection step drops TLSv1.1 on modern JVMsenabled_protocolsexplicitly includesTLSv1.1, confirming the hard startup error pathCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.