Open
Conversation
Signed-off-by: Deepti Chauhan <dchauhan3@atlassian.com> Signed-off-by: Deepti24 <chauhan.deepti24@gmail.com>
Signed-off-by: Deepti24 <chauhan.deepti24@gmail.com>
Signed-off-by: Deepti24 <chauhan.deepti24@gmail.com>
Signed-off-by: Deepti24 <chauhan.deepti24@gmail.com>
Signed-off-by: Deepti24 <chauhan.deepti24@gmail.com>
e9af95f to
11c2d20
Compare
This was referenced Mar 10, 2026
Author
|
@cwperks I have added relevant changes here as well: opensearch-project/OpenSearch#20822 A new method getTransients is added to ActionPlugin class. We could have reused headers but felt like it would be unclear which fields are transients to recover in security plugin within headers map. Also, responsibility wise both looked different. Do let me know if my understanding is incorrect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the fix for the security plugin issue mentioned here: https://github.com/opensearch-project/opensearch/issues/20517
Problem was that security plugin was using restore method from thread context which is overriding the transients (which store span id as well)
Issues Resolved
https://github.com/opensearch-project/opensearch/issues/20517
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
UNIT TESTS:
Added a unit to see if I set span id in transients and call restore and try to set it again later, I will able to generate traces successfully. To avoid static mocking in junits, I have tested required functionality by creating a mocked scenario. Do let me know if I should use static mocking for the same
MANUAL TESTS:
Steps:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.