Open
Conversation
When MergeYaml.parse() fails, the actual parsing error (stored in a ParseExceptionResult marker on the ParseError) was being silently discarded by the Yaml.Documents instanceof filter, resulting in an unhelpful "Could not parse as YAML" message. Now the ParseExceptionResult message is extracted and included in the IllegalArgumentException, making it possible to diagnose the root cause (e.g. SnakeYAML syntax errors, print-idempotence failures).
Member
Author
|
We saw this somehow pass validation but fail during execution, so rewrote the logic to capture and forward any parse failure message. |
MBoegers
reviewed
Feb 27, 2026
| try { | ||
| incoming = MergeYaml.parse(yaml); | ||
| return true; | ||
| } catch (IllegalArgumentException e) { |
Contributor
There was a problem hiding this comment.
It feels strange to have an exception to signal failure. Failure is nothing special its expected in validation.
Also, creating an exception causes stack walking to fill the stacktrace and JIT deopt, maybe not very strong arguments in our case but still.
We could omit the exception and instead return the parsing error or erroneous and check with instaceof?
Contributor
There was a problem hiding this comment.
or turn the parse into a validateParseable method and return a validation result insteadt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MergeYaml.parse()encountered a YAML parsing failure, themaybeParsemethod silently discarded theParseErrorresult (via aYaml.Documentsinstanceof filter), producing only a generic"Could not parse as YAML"messageParseExceptionResultmarker and includes it in theIllegalArgumentException, making failures diagnosable (e.g. SnakeYAML syntax errors, print-idempotence failures)maybeParsemethod and consolidates logic intoparse()Test plan
MergeYamlTesttests pass