Add test for ChangeParentPom retaining managed version from grandparent#6790
Draft
Add test for ChangeParentPom retaining managed version from grandparent#6790
Conversation
Member
Author
|
The context here is that a community user had reported an issue, but we've not yet been able to replicate it; we can keep this open for a short while to make it easier to suggest updates to the test, or otherwise close the PR again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ChangeParentPomwould not add an explicit version forspring-retrywhen upgradingspring-boot-starter-parentfrom 3.5.9 to 4.0.2, since Spring Boot 4 no longer managesspring-retry.What this PR does
Adds a test
bringsDownRemovedManagedVersionFromGrandparentthat verifiesChangeParentPomcorrectly retains managed versions even when the dependency management comes through a grandparent POM (e.g.spring-boot-starter-parent→spring-boot-dependencies).The test confirms that
ChangeParentPomdoes correctly:spring-retryis managed byspring-boot-starter-parent:3.5.9(viaspring-boot-dependencies:3.5.9)spring-boot-starter-parent:4.0.2no longer managesspring-retryspring-retrywith explicit version to<dependencyManagement>in the child POMThis is a regression test complementing the existing
bringsDownRemovedManagedVersiontest which only covers the single-level parent case (spring-boot-dependenciesdirectly).