Conversation
Contributor
Author
|
I want to check over one other thing regarding making sure it can detect correctly when we don't actually have any JUnit or TestNG annotations in the current class. |
steve-aom-elliott
changed the title
steve-aom-elliott
force-pushed
the
find-imports-refactor
branch
from
f2be2db to
e6c420f
Compare
…cutionListener Replace manual import loop in detectFramework() with FindImports search visitors for cleaner, more idiomatic framework detection.
Add a targetFramework @option that YAML wrapper recipes set based on ModuleHasDependency preconditions. Import-based detection still takes priority; the option is a fallback for files with no framework imports. Three YAML wrapper recipes gate on JUnit 5, JUnit 4, and TestNG dependencies respectively, replacing the single bare reference in Mockito1to3Migration.
Since JUnit 5 (org.junit.jupiter..*) is matched first, any remaining org.junit..* import is necessarily JUnit 4.
steve-aom-elliott
force-pushed
the
find-imports-refactor
branch
from
e6c420f to
d11ace5
Compare
timtebeek
changed the title
FindImports and dependency-aware framework detection in ReplaceMockitoTestExecutionListener
timtebeek
approved these changes
Mar 9, 2026
Contributor
Author
|
Going to put in another small PR because when the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectFramework()withFindImportssearch visitorstargetFrameworkoption for dependency-based framework detection when no imports are present...ForJUnit5,...ForJUnit4,...ForTestNG) gated byModuleHasDependencypreconditionsMockito1to3Migrationto use the wrapper recipes in priority orderWhen a file has
@TestExecutionListeners(MockitoTestExecutionListener.class)but no JUnit/TestNG imports (e.g., an abstract base class with only@Mockfields), the recipe previously defaulted to JUnit 5 blindly. Now the YAML wrappers check project dependencies to determine the correct framework.Import detection still takes priority over
targetFramework, so a TestNG file in a JUnit 5 project still gets TestNG treatment.Test plan
targetFrameworkfallback when file has no framework importstargetFramework