-
Notifications
You must be signed in to change notification settings - Fork 102
Add unit test showing null Methodinvocation type #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
greg-dennis
wants to merge
7
commits into
openrewrite:main
Choose a base branch
from
greg-dennis:bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−0
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6ed0601
Add unit test showing bug
f7b2844
Apply formatter
timtebeek ea4e2b2
Merge branch 'main' into bug
timtebeek ca0e483
Use static import
timtebeek 732813e
Merge branch 'main' into bug
timtebeek 29144a0
Apply suggestions from code review
timtebeek e59f795
Merge branch 'main' into bug
timtebeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
79 changes: 79 additions & 0 deletions
79
src/test/java/org/openrewrite/java/testing/cleanup/KotlinTestMethodShouldBeUnitTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright 2025 the original author or authors. | ||
| * <p> | ||
| * Licensed under the Moderne Source Available License (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * https://docs.moderne.io/licensing/moderne-source-available-license | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.openrewrite.java.testing.cleanup; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.openrewrite.ExecutionContext; | ||
| import org.openrewrite.InMemoryExecutionContext; | ||
| import org.openrewrite.Parser; | ||
| import org.openrewrite.SourceFile; | ||
| import org.openrewrite.java.tree.J; | ||
| import org.openrewrite.kotlin.KotlinIsoVisitor; | ||
| import org.openrewrite.kotlin.KotlinParser; | ||
| import org.openrewrite.test.RewriteTest; | ||
| import org.openrewrite.test.SourceSpec; | ||
|
|
||
| import java.nio.file.Path; | ||
| import java.util.Iterator; | ||
|
|
||
| import static java.util.Collections.singleton; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.openrewrite.kotlin.Assertions.kotlin; | ||
|
|
||
| // | ||
| class KotlinTestMethodShouldBeUnitTest implements RewriteTest { | ||
|
|
||
| @Test | ||
| void showNullMethodInvocationType() { | ||
| //language=kotlin | ||
| SourceSpec<?> source = getOnly( | ||
| kotlin( | ||
| """ | ||
| class ExampleTest { | ||
| fun myTest() = run { | ||
| return 1 | ||
| } | ||
| } | ||
| """ | ||
| )); | ||
| Parser parser = KotlinParser.builder().build(); | ||
| Path sourcePath = parser.sourcePathFromSourceText(source.getDir(), source.getBefore()); | ||
| ExecutionContext ctx = new InMemoryExecutionContext(); | ||
| Parser.Input input = Parser.Input.fromString( | ||
| sourcePath, source.getBefore(), parser.getCharset(ctx)); | ||
| SourceFile sourceFile = getOnly( | ||
| parser.parseInputs(singleton(input), null, ctx).toList()); | ||
| new FindMissingTypesVisitor().visit(sourceFile, ctx); | ||
| } | ||
|
|
||
| private static class FindMissingTypesVisitor extends KotlinIsoVisitor<ExecutionContext> { | ||
|
|
||
| @Override | ||
| public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, | ||
| ExecutionContext ctx) { | ||
| assertNotNull(method.getMethodType()); | ||
| return method; | ||
| } | ||
| } | ||
|
|
||
| private static <T> T getOnly(Iterable<T> iterable) { | ||
| Iterator<T> iter = iterable.iterator(); | ||
| T only = iter.next(); | ||
| assertFalse(iter.hasNext()); | ||
| return only; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've simplified it to this and am indeed seeing it fail in rewrite-testing-frameworks but succeed in rewrite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that simple example will show the symptom, but I found the failure to be more cryptic. The intention of the PR was to reveal the underlying issue: that the type of the
runmethod invocation is null.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Laurens-W, there appears to be other code that "expects" the types of Kotlin method invocations to sometimes be null (example). If that is sometimes "expected" behavior, the following workaround might make sense: openrewrite/rewrite#6409
Thoughts?