Add componentConsole config to decouple logging from storage location#1465
Add componentConsole config to decouple logging from storage location#1465leandrowilliam wants to merge 3 commits intoopencomponents:masterfrom
Conversation
… enable/disable console output explicitly
e965fe4 to
13ed32f
Compare
|
Hi, the distinction here is not local filesystem or remote storage, but local development or production. I don't think it's a great idea to let all components log on the registry without control. Even if we were I don't think enableComponentConsoleOutput is a great name, and even in that case, if we are going to give a pass to let components log, it might be better to let the the registry provide a console interface ({ componentConsole: console }), so perhaps you could pass a console interface that sends logs to a monitoring provider instead |
Got it, thanks for the clarification. I agree with that direction. I’ll update the approach and push the changes shortly |
|
@ricardo-devis-agullo Let me know if that works for you or if you think we should adjust anything else. Thanks Update: I also left a note in the issue |
|
@ricardo-devis-agullo Hi, do you have any updates on this one? Thanks |
Closes
Closes #1464
Overview
Allows component console output to be configured independently of the registry's storage location (local filesystem vs remote).
Solution
Add a new configuration option to control component logging, allowing:
cc: @kmcrawford @GinGatt