Use batch lookup and delete for monitorPIDEventsMap #1085
+10
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires Linux v5.6, but it reduces the load significantly for environments where there's a lot of process creation/exit churn. See: torvalds/linux@0579963 Signed-off-by: Ivan Babrou <github@ivan.computer>
florianl
reviewed
Jan 19, 2026
| // monitorPIDEventsMap periodically iterates over the eBPF map pid_events, | ||
| // collects PIDs and writes them to the keys slice. | ||
| func (t *Tracer) monitorPIDEventsMap(keys *[]libpf.PIDTID) { | ||
| eventsMap := t.ebpfMaps["pid_events"] |
Contributor
There was a problem hiding this comment.
As @fabled mentioned in #1079 (comment) it would be best, if the batch operations would be implemented in a transparent way, maybe similar we do for lookups, so that the process can fall back.
Contributor
Author
There was a problem hiding this comment.
I'll have a look at this later in the week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires Linux v5.6, but it reduces the load significantly for environments where there's a lot of process creation/exit churn.
See: torvalds/linux@0579963
Here's the flamegraph diff of this change deployed where you can see the new batched setup in red quite a bit smaller than the previous per key iteration in green: