-
Notifications
You must be signed in to change notification settings - Fork 364
Setup mdatagen in the collector module #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rogercoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense adding this to align with collector components. As a follow, we can migrate the internal telemetry to use mdatagen tool builder.
| class: receiver | ||
| codeowners: | ||
| active: | ||
| - dmathieu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the ebpf-profiler approvers/maintainers group instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can use groups for component codeowners. We could also ignore code owners here.
| "go.opentelemetry.io/collector/component" | ||
| "go.opentelemetry.io/collector/component/componenttest" | ||
| "go.opentelemetry.io/collector/confmap/confmaptest" | ||
| "go.opentelemetry.io/collector/receiver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This consumertest issue will be fixed with open-telemetry/opentelemetry-collector#14434
Mdatagen provides a fair bunch of generated tools that would be nice to use here, such as metrics generation.