refactor: replace strings.Split with strings.SplitSeq #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
florianl
reviewed
Jan 13, 2026
Contributor
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
Thanks for the quick update. Just one comment.
florianl
approved these changes
Jan 14, 2026
rogercoll
approved these changes
Jan 14, 2026
christos68k
reviewed
Jan 14, 2026
| expected := strings.Split(in, ",") | ||
| for tracer := range maxTracers { | ||
| if slices.Contains(expected, tracer.String()) && availableOnArch(tracer) { | ||
| found := false |
Member
There was a problem hiding this comment.
I'd revert this and keep the previous logic here, this code is both harder to understand and worse performance-wise.
Author
There was a problem hiding this comment.
Any other changes should i need to. make @christos68k ??
Member
There was a problem hiding this comment.
No, everything else looks OK to me.
Contributor
There was a problem hiding this comment.
@vishaal2002 can you revert this hunk? Looks good to me otherwise also. Thanks!
There was a problem hiding this comment.
I'm unable to revert the change since my temporary fork has been deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064