Closed
Conversation
added belpex spot price data for open-ideas#1305
Revised default connections between shading components when using Dou…
added Vliet building weather data file for 2021 for open-ideas#1303
Missing wind speed data Vliet building weather data
…ed according to the Modelica Language Specification (open-ideas#1314).
…ts within IDEAS.Buildings.Components.Shading.
…expandable, to avoid errors as mentioned in issue open-ideas#1317.
…nectors This closes open-ideas#1317
… baseclasses folder upwards for open-ideas#1244
- refactored partialsurface such that it includes CrackOrOperableDoor - CrackOrOperableDoor implements both a regular orifice equation and a door - depending on the settings of interzonalairflow the former or the latter is used - both in a window and an internal wall the operable door can be used to increase the air flow rate - control inputs are added for this - added an optional control signal for a trickle vent in a window - added unit tests for the above - the amount of diffuse/direct light entering the zone is reduced/increased depending on the window opening control signal - an input for adding custom water vapor to the zone model ahs been added - an input for adding custom co2 to the zone model ahs been added - an output for the relative humidity has been added to the zone model - the reflection coefficient implementation in the window has been improved - the bridge type implementation has been refactored such that the user no longer must provide the bridge type length to get a reasonable estimate of the bridge
Member
Author
|
when reviewing this it could help to first merge #1322 since those changes are included here too. |
Member
Author
|
Note that I have revised the screen model equations since the new implementation seems more correct to me. I.e. the non-absorbed fraction of direct solar radiation is not converted into diffuse solar irradiation but it stays direct instead. |
Contributor
Member
Author
|
done, but we'd better merge the stack effect branch first such that we can see the diff compared to that branch once it's finalised. |
Member
Author
|
@jelgerjansen it seems that the merge of the master branch breaks the code |
Merged
Contributor
|
The changes of this PR are included in #1327. Further development of project itz fixes will take place in that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jelgerjansen these are the changes that I have announced. A summary:
- refactored partialsurface such that it includes CrackOrOperableDoor
- CrackOrOperableDoor implements both a regular orifice equation and a door
- depending on the settings of interzonalairflow the former or the latter is used
- both in a window and an internal wall the operable door can be used to increase the air flow rate
- control inputs are added for this
- added an optional control signal for a trickle vent in a window
- added unit tests for the above
- the amount of diffuse/direct light entering the zone is reduced/increased depending on the window opening control signal
- an input for adding custom water vapor to the zone model ahs been added
- an input for adding custom co2 to the zone model ahs been added
- an output for the relative humidity has been added to the zone model
- the reflection coefficient implementation in the window has been improved
- the bridge type implementation has been refactored such that the user no longer must provide the bridge type length to get a reasonable estimate of the bridge
- n50 value computed based on total window surface area instead of just the glass
- revised direct solar absorption implementation of the screen
I have added some new unit tests for which I could not generate reference results. Can you help out with this?