[CI] Switch from buildjet to blacksmith runners#8483
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughReplace CI runner labels with blacksmith-*-ubuntu-2404 across workflows and test-matrix configs, add a workflow_dispatch trigger to CI, and add a trigger-and-wait post-step to image_builds to invoke and log secure build runs. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/image_builds.yml:
- Around line 149-152: The log prints a reconstructed URL using
vars.SECURE_BUILDS_REPO and steps.trigger-secure-build.outputs.workflow_id which
can be wrong if the dispatched repo differs; instead use the action's actual
output: replace the echo that builds the URL with the workflow_url output from
the trigger step (steps.trigger-secure-build.outputs.workflow_url) so the
printed "Secure build for ${matrix.role}" link exactly matches the triggered run
from convictional/trigger-workflow-and-wait@v1.6.5.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 911b4d8e-55ac-4fe5-8615-785128dff8df
📒 Files selected for processing (6)
.github/workflows/ci.yml.github/workflows/image_builds.ymltools/test_matrix_generator/default-test-matrix-config.jsontools/test_matrix_generator/insecure-module-test-matrix-config.jsontools/test_matrix_generator/integration-module-test-matrix-config.jsontools/test_matrix_generator/matrix_test.go
Description
Switch to a new runner service, Blacksmith, since BuildJet is shutting down.
Changes:
buildjetrunners24.04Notes
Closes https://github.com/onflow/ff-sre-infrastructure/issues/1167.
Summary by CodeRabbit