Replace mapLoadedValueIterator wrapper by using Atree implementation

[fxamacker]

Requires onflow/atree#635
Updates #4442

This PR replaces mapLoadedValueIterator added by PR #4442.

Atree implements MapIterator interface for MapLoadedValueIterator in PR:

• Implement Iterator interfaces for LoadedValueIterator atree#635

This PR removes mapLoadedValueIterator and uses the implementation in Atree as suggested by @turbolent. 👍

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[turbolent]

Nice, thank you!

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details
gomod/github.com/onflow/atree	0.14.0	🟢 8.8	Details Check Score Reason Code-Review 🟢 10 all changesets reviewed Maintained 🟢 10 30 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10 Packaging ⚠️ -1 packaging workflow not detected Security-Policy 🟢 10 security policy file detected Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Binary-Artifacts 🟢 10 no binaries found in the repo Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Pinned-Dependencies 🟢 10 all dependencies are pinned License 🟢 10 license file detected Fuzzing ⚠️ 0 project is not fuzzed Signed-Releases ⚠️ -1 no releases found Branch-Protection ⚠️ -1 internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md SAST 🟢 10 SAST tool is run on all commits
gomod/github.com/onflow/atree	0.14.0	🟢 8.8	Details Check Score Reason Code-Review 🟢 10 all changesets reviewed Maintained 🟢 10 30 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10 Packaging ⚠️ -1 packaging workflow not detected Security-Policy 🟢 10 security policy file detected Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Binary-Artifacts 🟢 10 no binaries found in the repo Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Pinned-Dependencies 🟢 10 all dependencies are pinned License 🟢 10 license file detected Fuzzing ⚠️ 0 project is not fuzzed Signed-Releases ⚠️ -1 no releases found Branch-Protection ⚠️ -1 internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md SAST 🟢 10 SAST tool is run on all commits

Scanned Files

• go.mod
• tools/compatibility-check/go.mod

[github-actions]

Benchstat comparison

• Base branch: onflow:master
• Base commit: b5b2fb9

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.27µs ± 0%	1.25µs ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	82.9ns ± 0%	78.7ns ± 0%	~	(p=1.000 n=1+1)
ByteSliceToByteArrayValue-4	985ns ± 0%	916ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	415µs ± 0%	415µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	3.64µs ± 0%	3.30µs ± 0%	~	(p=1.000 n=1+1)
Emit-4	4.50ms ± 0%	4.66ms ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	1.40µs ± 0%	1.32µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	266ns ± 0%	266ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	77.7ns ± 0%	77.8ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	22.7µs ± 0%	22.6µs ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	2.24ms ± 0%	2.24ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	844ns ± 0%	861ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	324ns ± 0%	324ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	647µs ± 0%	625µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	707µs ± 0%	715µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.84ms ± 0%	2.66ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	9.90ms ± 0%	9.78ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	14.3µs ± 0%	14.7µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	40.8µs ± 0%	41.1µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	59.0ns ± 0%	58.7ns ± 0%	~	(p=1.000 n=1+1)
	alloc/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.08kB ± 0%	1.07kB ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	860B ± 0%	844B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	146kB ± 0%	146kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	2.45kB ± 0%	2.46kB ± 0%	~	(p=1.000 n=1+1)
Emit-4	1.50MB ± 0%	1.51MB ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	827B ± 0%	837B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	170kB ± 0%	171kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	192kB ± 0%	193kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.76MB ± 0%	1.76MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	6.98MB ± 0%	6.98MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.05kB ± 0%	8.06kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	13.3kB ± 0%	13.3kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
	allocs/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	7.00 ± 0%	7.00 ± 0%	~	(all equal)
ByteArrayValueToByteSlice-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	5.00 ± 0%	5.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.42k ± 0%	2.42k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
Emit-4	40.0k ± 0%	40.0k ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	3.27k ± 0%	3.27k ± 0%	~	(all equal)
RuntimeFungibleTokenTransferVM-4	3.73k ± 0%	3.73k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(all equal)
RuntimeResourceTracking-4	129k ± 0%	129k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	114 ± 0%	114 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	424 ± 0%	424 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)