Merged
Conversation
nialexsan
changed the title
jordanschalm
reviewed
Mar 9, 2026
jordanschalm
approved these changes
Mar 10, 2026
Member
jordanschalm
left a comment
jordanschalm
left a comment
There was a problem hiding this comment.
Looks good. Just a comment on the event balance field to make it always reflect the net withdrawal.
| from: <-sinkVault, | ||
| poolUUID: self.uuid, | ||
| atHealth: balanceSheet.health, | ||
| amount: sinkVault.balance, |
Member
There was a problem hiding this comment.
Should this be the actual amount withdrawn to the sink? Given the conditional on line 3806, we might for example withdraw 100X from our position, then attempt to push that 100X to the sink, but the sink only accepts 50X, so we re-deposit the remaining 50X (net withdrawal of 50X).
I think the event should reflect the net withdrawal in this case.
Collaborator
Author
There was a problem hiding this comment.
I'll create an issue for this to track it, and address it with the other event related tasks
| pid: pid, | ||
| poolUUID: self.uuid, | ||
| atHealth: balanceSheet.health, | ||
| amount: sinkVault.balance, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #???
Description
Allow borrowing tokens from reserves, not just MOET
For contributor use:
masterbranchFiles changedin the Github PR explorer