FLO-23: attempt topUpSource rebalance before manual liquidation#250
Open
FLO-23: attempt topUpSource rebalance before manual liquidation#250
Conversation
Member
jordanschalm
left a comment
jordanschalm
left a comment
There was a problem hiding this comment.
I don't think this suggestion from the audit is a good idea.
It's important to let users add collateral or pay debt from their preferred source when possible, but I think attempting that here risks preventing liquidations from occurring smoothly. Calling into the top-up source during a liquidation involves executing user-provided code. What if the top-up source reads its position's health and panics if health<1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #232
Calls
_rebalancePositionNoLock(force: true)at the start ofmanualLiquidationbefore evaluating position health. If the configured topUpSource has sufficient funds to restore health, the liquidation reverts, preventing third parties from liquidating positions that the user has properly secured.