Skip to content

Validate debt type before withdrawal credit-to-debit flip #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liobrasil wants to merge 2 commits into
base: nialexsan/multi-debt
Choose a base branch
from
Open

Validate debt type before withdrawal credit-to-debit flip #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a82da5
Validate debt type before credit-to-debit withdrawal flip
liobrasil Mar 4, 2026
c076db9
Merge branch 'nialexsan/multi-debt' into lionel/fix-withdraw-validati…
liobrasil Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions cadence/contracts/FlowALPv0.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,20 +1558,25 @@ access(all) contract FlowALPv0 {
positionBalance = position.getBalance(type)
}

// Reflect the withdrawal in the position's balance
// Reflect the withdrawal in the position's balance.
// If this withdrawal would flip an existing Credit balance into Debit,
// validate before mutating so user-facing debt-type errors are emitted
// instead of hitting the invariant assert after mutation.
let wasCredit = positionBalance!.direction == FlowALPModels.BalanceDirection.Credit
let uintAmount = UFix128(amount)
if wasCredit {
let trueBalanceBefore = FlowALPMath.scaledBalanceToTrueBalance(
positionBalance!.scaledBalance,
interestIndex: tokenState.getCreditInterestIndex()
)
if uintAmount > trueBalanceBefore {
position.validateDebtType(type)
}
}
position.borrowBalance(type)!.recordWithdrawal(
amount: uintAmount,
tokenState: tokenState
)

// If we flipped from Credit to Debit, validate debt type constraint
// Re-fetch balance to check if direction changed
positionBalance = position.getBalance(type)
if wasCredit && positionBalance!.direction == FlowALPModels.BalanceDirection.Debit {
position.validateDebtType(type)
}
// Attempt to pull additional collateral from the top-up source (if configured)
// to keep the position above minHealth after the withdrawal.
// Regardless of whether a top-up occurs, the position must be healthy post-withdrawal.
Expand Down