refactor(codec): simplify type-erased handlers#45
Merged
Conversation
…ayers - Merge SpanEdit into Span and SpanEditStream into SpanStream - Remove Document<H> wrapper, fold source() into Handler trait - Replace AnyImage/AnyAudio enums with BoxedImageHandler/BoxedAudioHandler - Remove span_id generic from ImageRedaction and AudioRedaction - Remove Concrete marker trait, use explicit DynHandler impls with Handler supertrait - Make document span/stream modules private, expose only via re-exports Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…e visibility - Extract shared audio handler boilerplate into impl_audio_handler! macro - Fix stale doc comments referencing removed view_spans/edit_spans methods - Make all handler struct fields private (were inconsistently pub(crate)) - Add new() constructors to JsonHandler and CsvHandler, update loaders - Remove unused as_*/into_* accessor boilerplate from AnyText and AnyRich - Add TODO comment for unimplemented audio redaction stub Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename AnyDocument → Document, PdfHandler → RichTextHandler - Delete DocxHandler stub, replaced by format-agnostic RichTextHandler - Inline AudioSpanId into AudioHandler trait, removing associated type - Eliminate DynAudioHandler — AudioHandler is now directly object-safe - Add method-level docs to all handler and Dyn* traits Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eHandler - Remove associated type from ImageHandler, use ImageSpanId directly - Eliminate DynImageHandler trait and impl_dyn_image! macro - Simplify BoxedImageHandler to wrap Box<dyn ImageHandler> directly - Move AudioSpanId and ImageSpanId to own files, wrap Option<u32> - Remove ImageHandler impl and RichImageSpan from RichTextHandler - Remove H::ImageId: Default bound from ImageTransform Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Derive Default for XlsxHandler to satisfy clippy::new_without_default - Update quinn-proto 0.11.13 → 0.11.14 (RUSTSEC-2026-0037, DoS fix) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…de_image - Replace hand-written From/as_*/into_* on Document with derive_more (From, IsVariant, TryInto); inline Document into document/mod.rs - Add Default derive to all 11 loader structs - Move decode_image into ImageData::decode with built-in tracing - Add utility methods to AudioSpanId/ImageSpanId (new, index, From<u32>) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Consolidate magic-byte detection in nvisy-core via `infer`. ContentData gains `detect_mime()`, `document_type()` (caching), and `infer_document_type()` (non-caching). nvisy-codec adds a `detect` module with `decode()` that auto-dispatches ContentData to the right loader with default params. Remove `infer` from nvisy-codec deps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move the free `decode()` function into `Document::decode()` as an associated method and delete the `detect` module. Detection tests moved to nvisy-core alongside `infer_document_type`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reorganise nvisy-core modules to reflect their actual purpose: - `fs` → `media`: format classification (ContentKind, DocumentType) - `io` → `content`: data containers, metadata, source identity - `path` → folded into `content`: ContentSource now lives alongside the content types that reference it - ContentMetadata moved from media to content (it's content metadata, not format classification) - content/content.rs renamed to content/bundle.rs to avoid clippy module name collision Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Same pattern as BoxedImageHandler, BoxedAudioHandler, and BoxedRichHandler — a boxed trait object with DynTextHandler bridge trait and impl_dyn_text! macro for each concrete handler. From impls generated by the macro replace the hand-rolled enum variants. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove 24 tests across nvisy-core and nvisy-codec that tested auto-derived behavior (Display, FromStr, Serialize, From conversions, trivial constructors) without exercising any meaningful logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Consumers now import `nvisy_codec::Span` instead of `nvisy_codec::document::Span`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.