Introduce tmp path to better handle stdin#624
Merged
brianmcgee merged 2 commits intomainfrom Sep 15, 2025
Merged
Conversation
Signed-off-by: Brian McGee <brian@bmcgee.ie>
Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/tmp-path
branch
from
47c5688 to
b68d328
Compare
jfly
approved these changes
Aug 30, 2025
Collaborator
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
A couple thoughts inline, not blockers.
jfly
reviewed
Aug 30, 2025
jfly
approved these changes
Aug 31, 2025
|
These don’t get cleaned up properly in some cases, leading to e.g. It also has a non‐trivial performance penalty. I guess this is intended as a stop‐gap until #573 and #586 can be solved? Edit: I guess files were being created anyway, so the performance part isn’t relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620