Fix false-negative GET/HEAD/RANGE#3840
Merged
roman-khimov merged 3 commits intomasterfrom Feb 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3840 +/- ##
==========================================
- Coverage 25.58% 25.57% -0.02%
==========================================
Files 667 667
Lines 42941 42936 -5
==========================================
- Hits 10988 10979 -9
- Misses 30949 30952 +3
- Partials 1004 1005 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This part was always incorrect. The problem didn't manifest itself because the client constructor didn't return network errors. At least until 4dea9e2: now remote SN info query is executed, and errors may be returned to it. This makes server to continue request processing by switching to another SN to get data from. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Simplify code a bit. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
fix-get-false-negative
branch
from
910b1fe to
6fae0b6
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
roman-khimov
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.