Open
Conversation
4 tasks
AnnaShaleva
force-pushed
the
import-parsing
branch
from
7296e91 to
93dbc8b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3813 +/- ##
==========================================
- Coverage 25.53% 25.45% -0.09%
==========================================
Files 669 668 -1
Lines 42940 42846 -94
==========================================
- Hits 10966 10906 -60
+ Misses 30971 30946 -25
+ Partials 1003 994 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AnnaShaleva
force-pushed
the
import-parsing
branch
from
93dbc8b to
09edf3c
Compare
Member
Author
|
Testsuit run is in progress, but the PR itself is ready for review. |
AnnaShaleva
requested review from
End-rey,
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Member
Author
|
Full testsuite passed successfully: https://github.com/nspcc-dev/neofs-node/actions/runs/21943824243 |
No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
import-parsing
branch
from
09edf3c to
f45bd0b
Compare
Replace custom AppCall argument parsers with built-in NeoGo's ones. Other related functional changes: 1. Remove container.PutNamed structure since it duplicates container.Put functionality starting from c6c6aea. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This type argument is excessive and misleading since scparser doesn't operate with VM types. Also, scparser offers detailed error information by himsel, no further extension is necessary. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
It's used in two places, and it's a duplicate of event.WrongNumberOfParameters. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Parsers from `pkg/morph/event/...` will reuse this common code. No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Reuse `event.GetValueFromArg`, `event.GetArgs` and `event.WrapInvalidArgError` where possible. Take care of errors text, unify invalid argument errors, remove excessive information. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This code complicates things for nothing and may lead to bugs related to structure fields order initialization. Raw parsing is more clear and takes less space. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
import-parsing
branch
from
f45bd0b to
123dbc9
Compare
Member
Author
|
@nspcc-dev/neofs-core updated, ready for review. |
| } | ||
|
|
||
| // CreateContainerRequest wraps container creation request to provide | ||
| // CreateContainerV2Request wraps container creation request to provide |
| err error | ||
| ) | ||
|
|
||
| if err = res.Container.FromStackItem(stack.Pop().Item()); err != nil { |
Member
There was a problem hiding this comment.
Just as a thought: type Item interface can be implemented by Instruction as well (all type switches based on specific stackitems will go wild though).
| func ParsePutNotary(ne event.NotaryEvent) (event.Event, error) { | ||
| var ev Put | ||
| const putArgCnt = 3 | ||
| var ev = new(Put) |
| ### Changed | ||
| - SN retries notary requests if `insufficient amount of gas` error appears (#3739) | ||
| - Speed up metabase resync by using batch operations (#3804) | ||
| - Notary events parsing is now done via NeoGo `scparser` package (#3813) |
Member
There was a problem hiding this comment.
Not sure it's worth mentioning at all, it's deeply internal to node. And this is outdated wrt 0.51.1 release as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: