Skip to content

Comments

Deprecate response verification header#374

Merged
cthulhu-rider merged 1 commit intomasterfrom
response-signatures
Feb 6, 2026
Merged

Deprecate response verification header#374
cthulhu-rider merged 1 commit intomasterfrom
response-signatures

Conversation

@cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Jan 26, 2026

No description provided.

@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality blocked Can't be done because of something labels Jan 26, 2026
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Jan 26, 2026
Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Jan 26, 2026
Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Jan 26, 2026
From nspcc-dev/neofs-api@XXX.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this pull request Jan 26, 2026
Follow nspcc-dev/neofs-api#374.

Refs #3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this pull request Jan 28, 2026
Follow nspcc-dev/neofs-api#374.

Refs #3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review February 4, 2026 08:03
Spread #334 to all RPC.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider removed the blocked Can't be done because of something label Feb 4, 2026
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 4, 2026
From nspcc-dev/neofs-api@XXX.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
// Carries response verification information. This header is used to
// authenticate the nodes of the message route and check the correctness of
// transmission.
// DEPRECATED: the field is no longer used for verifications. Servers MUST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have reread the original issue, as i understood, we are agreed about some object operations, but what about balance? shouldn't it be signed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly JSON-RPC to FS chain node. Never signed. No value in doing it here as well.

@cthulhu-rider cthulhu-rider merged commit 8fb324b into master Feb 6, 2026
3 checks passed
@cthulhu-rider cthulhu-rider deleted the response-signatures branch February 6, 2026 13:55
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 6, 2026
From nspcc-dev/neofs-api@XXX.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 6, 2026
From nspcc-dev/neofs-api@8fb324b.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 9, 2026
From nspcc-dev/neofs-api@8fb324b.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 9, 2026
From nspcc-dev/neofs-api@8fb324b.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 10, 2026
From nspcc-dev/neofs-api@8fb324b.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 10, 2026
From nspcc-dev/neofs-api@8fb324b.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-sdk-go that referenced this pull request Feb 11, 2026
From nspcc-dev/neofs-api@8fb324b.

Follow nspcc-dev/neofs-api#374.

Needed for nspcc-dev/neofs-node#3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this pull request Feb 11, 2026
Follow nspcc-dev/neofs-api#374.

Refs #3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit to nspcc-dev/neofs-node that referenced this pull request Feb 20, 2026
Follow nspcc-dev/neofs-api#374.

Refs #3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants