This repository was archived by the owner on Dec 5, 2017. It is now read-only.
Added :identifier option to disqus_thread#4
Open
Osmose wants to merge 3 commits intonorman:masterfrom
Open
Conversation
added 3 commits
February 10, 2011 10:17
|
+1 I thins the disqus_url can be add too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, great gem. :P
I'm learning Rails and Ruby through Mozilla's Webcraft online course program, and used your gem to add comments to our blog sample project. I wanted to be able to refer to the same comment thread from multiple URLs (I have permalinks and you can also access posts via the post id). So I added the :identifier option to disqus_thread.
Let me know if I've made any big mistakes, still trying to learn the Right Way (tm) to do things in Ruby and Rails. :P Thanks!