Skip to content

Conversation

@MikeMcC399
Copy link
Contributor

Situation

BUILDING.md > Previous versions of this document provides links:

Change

In BUILDING.md > Previous versions of this document:

  1. remove end-of-life Node.js versions 21 and 18
  2. add supported LTS versions 24 and 22

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 21, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 21, 2026 07:45
@UlisesGascon UlisesGascon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2026
Copy link
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if there's a better approach than the perennially-stale hardlinks.

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Jan 22, 2026

@Renegade334

Wonder if there's a better approach than the perennially-stale hardlinks.

The section BUILDING.md > Previous versions of this document is incorrect in every supported branch and is only maintainable with explicit manual updates that are branch specific. This update task has slipped through the cracks and it would be good to avoid it for the future.

I would suggest to remove the links and replace instead with branch-agnostic text that advises to use BUILDING.md from the branch concerned.

If that sounds good, I would close this PR and open a new one to remove the links. That should be something that is easier to backport and would be perennially correct instead of perennially stale!

Edit: This PR is now in the commit-queue, so I will not close it. Suggestions or a PR to improve how to handle this topic better would need to be handled separately.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Jan 22, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2026
@nodejs-github-bot nodejs-github-bot merged commit c0b5d89 into nodejs:main Jan 23, 2026
54 of 55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c0b5d89

@MikeMcC399 MikeMcC399 deleted the update/building-previous-versions branch January 23, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants