-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
doc: update previous version links in BUILDING #61457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update previous version links in BUILDING #61457
Conversation
|
Review requested:
|
Renegade334
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if there's a better approach than the perennially-stale hardlinks.
The section BUILDING.md > Previous versions of this document is incorrect in every supported branch and is only maintainable with explicit manual updates that are branch specific. This update task has slipped through the cracks and it would be good to avoid it for the future. I would suggest to remove the links and replace instead with branch-agnostic text that advises to use BUILDING.md from the branch concerned. If that sounds good, I would close this PR and open a new one to remove the links. That should be something that is easier to backport and would be perennially correct instead of perennially stale! Edit: This PR is now in the commit-queue, so I will not close it. Suggestions or a PR to improve how to handle this topic better would need to be handled separately. |
|
Landed in c0b5d89 |
Situation
BUILDING.md > Previous versions of this document provides links:
Change
In BUILDING.md > Previous versions of this document: