-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
build,win: improve logs when ClangCL is missing #61438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jan 19, 2026
avivkeller
approved these changes
Jan 19, 2026
Collaborator
StefanStojanovic
approved these changes
Jan 20, 2026
legendecas
approved these changes
Jan 20, 2026
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in e9b0849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #61437
Situation
If Visual Studio is installed without ClangCL on Node.js >= 24, the logs from executing
.\vcbuildon Windows could be misinterpreted as suggesting that Visual Studio was missing, not ClangCL.Change
Make minor text changes in vcbuild.bat to ease troubleshooting when ClangCL has not been installed according to BUILDING.md instructions.
Example logs after change applied
Visual Studio missing
Visual Studio 2026 Build Tools installed incompletely
https://aka.ms/vs/stable/vs_BuildTools.exe installed 18.2.0
The failure logs are the same whether only "Desktop development with C++" is missing or ClangCL is missing, or both are missing:
Prerequisites installed
Logs with all prerequisites installed and no errors reported concerning missing components: