Skip to content

[ServiceDB] handle exception #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaeyun-jung wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

[ServiceDB] handle exception #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions daemon/service-db.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,9 +876,15 @@
delete g_svcdb_instance;
}

g_svcdb_instance = new MLServiceDB (path);
try {
g_svcdb_instance = new MLServiceDB (path);

Check warning on line 880 in daemon/service-db.cc

View workflow job for this annotation

GitHub Actions / cpp-linter

daemon/service-db.cc:880:5 [cppcoreguidelines-owning-memory] 

assigning newly created 'gsl::owner<>' to non-owner 'MLServiceDB *'
g_svcdb_instance->connectDB ();
} catch (const std::exception &e) {
ml_loge ("%s", e.what ());
svcdb_finalize ();
}

Copy link
Contributor

@songgot songgot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code below is right ?

try {
    g_svcdb_instance = new MLServiceDB (path);
    g_svcdb_instance->connectDB ();
    g_assert (g_svcdb_instance);  // when succeed ?
  } catch (const std::exception &e) {
    ml_loge ("%s", e.what ());
    svcdb_finalize ();
  }

Copy link
Contributor Author

@jaeyun-jung jaeyun-jung Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, db instance should be a valid pointer when calling initialization.

g_assert (g_svcdb_instance);
g_svcdb_instance->connectDB ();
}

/**
Expand Down