Feat/student activites by kartik-vats · Pull Request #569 · nitkkr-dev/nitkkr

kartik-vats · 2026-03-03T13:18:31Z

No description provided.

Copilot

Pull request overview

This PR updates the Student Activities area by expanding the page content/sections (societies, council members, Thought Lab, NSS/NCC) and updating related translations, alongside a small dependency bump for TipTap’s image extension.

Changes:

Bump @tiptap/extension-image from ^3.19.0 to ^3.20.0 (and corresponding lockfile updates).
Extend Student Activities translations (EN/HI) to add “societies” and switch some section fields from more to content.
Refactor app/[locale]/student-activities/page.tsx to add new sections and integrate StudentGroup for council members.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 10 comments.

File	Description
package.json	Updates TipTap image extension version.
package-lock.json	Updates resolved TipTap packages to match the dependency bump.
i18n/translate/student-activities.ts	Adds societies + new `content` fields for Thought Lab/NSS/NCC (EN/HI).
app/[locale]/student-activities/page.tsx	Adds new page sections, council member rendering, and adjusts clubs rendering layout.

Comments suppressed due to low confidence (1)

i18n/translate/student-activities.ts:56

title: 'NATIONAL SERVICE SCHEME (NSS) ' has a trailing space inside the string. This will render visibly in some UI contexts; please remove the extra space.

      title: 'NATIONAL SERVICE SCHEME (NSS) ',
      content:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-03T19:26:39Z

app/[locale]/student-activities/page.tsx

@@ -9,6 +9,7 @@ import { BouncyArrowButton } from '~/components/buttons';
 import { GalleryCarousel } from '~/components/carousels';


GalleryCarousel is imported but no longer used after switching the carousel markup to a plain <div> grid. This will trip lint/typecheck; remove the unused import (or reintroduce GalleryCarousel).

Suggested change

import { GalleryCarousel } from '~/components/carousels';

Copilot · 2026-03-03T19:26:40Z

app/[locale]/student-activities/page.tsx

+
+                            <Link
+                             href={`/${locale}/student-activities/thought-lab`}                              className="absolute bottom-4 left-4 font-serif text-2xl font-semibold text-shade-light hover:underline"
+                              target="_blank"


This Link uses target="_blank" but doesn’t set rel="noopener noreferrer". Add the rel attribute to prevent reverse-tabnabbing (even for internal links).

Suggested change

target="_blank"

target="_blank"

rel="noopener noreferrer"

Copilot · 2026-03-03T19:26:40Z

app/[locale]/student-activities/page.tsx

+
+                          {/* Right: Description */}
+                          <p className="text-gray-800 text-justify leading-relaxed">
+                            {text.sections.nss.content}


In the NCC section, the description is rendering text.sections.nss.content instead of text.sections.ncc.content, so NCC will show the NSS copy.

Suggested change

{text.sections.nss.content}

{text.sections.ncc.content}

Copilot · 2026-03-03T19:26:40Z

app/[locale]/student-activities/page.tsx

+          { label: text.headings.events, href: '#events' },
+          { label: text.headings.council, href: '#council' }, 
+          {label: text.headings.thoughtLab, href: '#thought-lab',},
          { label: text.headings.nss, href: '#nss' },
-          { label: text.headings.ncc, href: 'student-activities/ncc' },
+          { label: text.headings.ncc, href: '#ncc' },
+
+
        ]}


This file appears to be unformatted relative to the repo’s Prettier rules (e.g. inconsistent spacing in object literals, extra blank lines). Since CI runs npm run format:check, please run npm run format on this file to avoid formatting check failures.

Copilot · 2026-03-03T19:26:40Z

i18n/translate/student-activities.ts

+    societies: {
+      title: "TECHNICAL SOCIETIES",
+      more: "Explore all technical societies"
+    },


This file doesn’t match the repo’s Prettier config (singleQuote: true, trailing commas, etc.). For example, the new societies strings use double quotes and the object formatting is inconsistent; running npm run format should normalize this and prevent format:check from failing.

Copilot · 2026-03-03T19:26:41Z

app/[locale]/student-activities/page.tsx

+        className="container"
+        glyphDirection="ltr"
+        heading="h3"
+        href={`/${locale}/student-activities/societies`}     


href={/${locale}/student-activities/societies} points to a route that doesn’t exist in app/[locale]/student-activities/ (there’s no societies/ page), so this link will 404. Either add the missing route or change the link to an on-page anchor (e.g. #societies) / an existing page.

Suggested change

href={`/${locale}/student-activities/societies`}

href="#societies"

Copilot · 2026-03-03T19:26:41Z

app/[locale]/student-activities/page.tsx

+      <section className="container mb-6 text-center">
+        <Suspense fallback={<Loading />}>
+          <ClubsCarousel locale={locale} />
+        </Suspense>


<ClubsCarousel /> is rendered in both the Clubs and Societies sections, and it performs a DB query each time. This duplicates the same query/render work in a single request; consider fetching the clubs list once in StudentActivities and passing it down (or memoizing) so the page only hits the DB once.

Copilot · 2026-03-03T19:26:41Z

app/[locale]/student-activities/page.tsx

@@ -63,9 +109,138 @@ export default async function StudentActivities({
            variant: 'outline',
          }}
          linkProps={{ href: `/${locale}/student-activities/clubs` }}


The council CTA text is text.sections.council.more (“View All Members”), but the button link still points to /${locale}/student-activities/clubs. This will take users to the wrong destination; update linkProps.href to the council destination (or change the text back to the clubs CTA).

Suggested change

linkProps={{ href: `/${locale}/student-activities/clubs` }}

linkProps={{ href: `/${locale}/student-activities/council` }}

Copilot · 2026-03-03T19:26:42Z

app/[locale]/student-activities/page.tsx

+    <Link
+ href={`/${locale}/student-activities/nss`}
+       className="absolute bottom-4 left-4 font-serif text-2xl font-semibold text-shade-light hover:underline"
+      target="_blank"
+    >


This Link opens a new tab (target="_blank") without rel="noopener noreferrer". Please add rel to avoid reverse-tabnabbing.

Copilot · 2026-03-03T19:26:42Z

app/[locale]/student-activities/page.tsx

+                            <Link
+                              href={`/${locale}/student-activities/ncc`}
+                              className="absolute bottom-4 left-4 font-serif text-2xl font-semibold text-shade-light hover:underline"
+                              target="_blank"


This Link uses target="_blank" but is missing rel="noopener noreferrer". Add rel for security.

Suggested change

target="_blank"

target="_blank"

rel="noopener noreferrer"

Debatreya · 2026-03-05T17:28:16Z

@kartik-vats
Package.json and Package-lock.json pe change nhi aana chaiye tha.
Yeh fix kr de fer baki dkhta hu

Debatreya · 2026-03-10T17:08:11Z

How its looking, is not that correct

Aryawart-kathpal · 2026-03-11T04:06:19Z

The section is covering the whole desktop space.. which it should not.. you might have forgot to use the 'container' class..
Same for NSS and NCC

Aryawart-kathpal · 2026-03-11T04:07:23Z

When i clicked on the 'view all members' on the student council.. it is not redirecting to the correct link. FIX THAT

Aryawart-kathpal · 2026-03-11T04:09:05Z

This is not exactly according to what we expected.. for reference you can see courses and departments on /academics

Aryawart-kathpal · 2026-03-11T04:10:09Z

Also the Thought Lab,NCC and NSS links are opening in other tabs. They should be redirected in the same tab only. FIX

Aryawart-kathpal · 2026-03-11T04:12:42Z

Also fix the indentation using prettier and check if any other lint warnings or errors are there

Aryawart-kathpal · 2026-03-11T04:14:00Z

Translations are missing for this text in Though lab,NCC and NSS.

Aryawart-kathpal · 2026-03-11T04:15:21Z

The content for NCC is also same as NSS. Fix required.

Aryawart-kathpal · 2026-03-11T04:16:01Z

Also no changes in package and package lock required.. take help of Debatreya to resolve this.

Aryawart-kathpal

Check the comments above and apply Fixes.

kartik-vats added 2 commits March 3, 2026 18:01

student-activites

c575198

Fix: updated NSS and NCC content

7a42020

kartik-vats changed the base branch from master to staged March 3, 2026 13:18

Debatreya requested a review from Copilot March 3, 2026 19:20

Copilot started reviewing on behalf of Debatreya March 3, 2026 19:21 View session

Debatreya assigned Aryawart-kathpal Mar 3, 2026

Copilot AI reviewed Mar 3, 2026

View reviewed changes

your message

9230b2f

vercel bot deployed to Preview March 10, 2026 17:04 View deployment

Aryawart-kathpal self-requested a review March 11, 2026 04:03

Aryawart-kathpal requested changes Mar 11, 2026

View reviewed changes

		@@ -9,6 +9,7 @@ import { BouncyArrowButton } from '~/components/buttons';
		import { GalleryCarousel } from '~/components/carousels';

	href={`/${locale}/student-activities/societies`}
	href="#societies"

	linkProps={{ href: `/${locale}/student-activities/clubs` }}
	linkProps={{ href: `/${locale}/student-activities/council` }}

Conversation

kartik-vats commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Debatreya commented Mar 5, 2026

Uh oh!

Debatreya commented Mar 10, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal commented Mar 11, 2026

Uh oh!

Aryawart-kathpal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants