Fix some vertex index overflow issues in geometry builders#942
Merged
nical merged 2 commits intonical:mainfrom Mar 8, 2026
Merged
Fix some vertex index overflow issues in geometry builders#942nical merged 2 commits intonical:mainfrom
nical merged 2 commits intonical:mainfrom
Conversation
See the newly-added `overflow_with_vertex_offset` test.
- `u32::MAX` shouldn't be a valid output vertex index (it's `VertexId::INVALID`); - `<isize as MaxIndex>::MAX` had the wrong value on 32 bit targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuffersBuilder::with_vertex_offsetwith large values cannot overflowOutputVertexindices.MaxIndexbounds foru32, u64, i64, usize, isize:VertexId::INVALIDwasn't properly excluded, andisizehad the entirely wrong value on 32-bit targets.