-
-
Notifications
You must be signed in to change notification settings - Fork 220
Describer: checked method existence #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vrana
wants to merge
16
commits into
nette:master
Choose a base branch
from
vrana:exception
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thanks |
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
be881cd to
db11685
Compare
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
bee1f04 to
7ffe057
Compare
dg
pushed a commit
that referenced
this pull request
Feb 8, 2026
Prevents exception inside exception handler that could kill PHP-FPM silently
9699205 to
c2ab3e5
Compare
d5953ee to
bf88f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't pinpoint the exact configuration (my PHP version is 8.4.16) but under some conditions, an exception thrown inside an exception handler kills PHP-FPM in the most brutal way with no errors logged or printed anywhere. Debugging this was a nightmare. A simple check for function existence fixes the problem.