Conversation
langecode
left a comment
langecode
left a comment
There was a problem hiding this comment.
With the risk of repeating a conversation that had already been done - I have added a few comments.
| if: inputs.run-benchmarks | ||
| run: go test -bench=./... | ||
|
|
||
| - name: Install GoReleaser |
There was a problem hiding this comment.
Are we using GoRelease for building container images? Or should this be optional? Do we need a simple go build ./... as part of the pipeline also?
There was a problem hiding this comment.
@langecode
I think we could use it for container images yes, and GoReleaser does run build ./.. and CI would also had done this.
Otherwise consumers can also customize as they see fit using the .goreleaser file.
There was a problem hiding this comment.
Ok, so we outsource go build ./... to GoReleaser regardless of the project containing a .goreleaser configuration or not. Guess that makes sense then - just not very obvious reading the pipeline that GoReleaser will run this
langecode
left a comment
langecode
left a comment
There was a problem hiding this comment.
I think it looks pretty good 👍
Only thing that I think we could add (but we could also do that later) is posting the test-results to the Github action for more easy overview if tests are failing. I think there is also integrations for publishing test-coverage. But we should possibly let this rest and do it as a separate thing sometime.
| if: inputs.run-benchmarks | ||
| run: go test -bench=./... | ||
|
|
||
| - name: Install GoReleaser |
There was a problem hiding this comment.
Ok, so we outsource go build ./... to GoReleaser regardless of the project containing a .goreleaser configuration or not. Guess that makes sense then - just not very obvious reading the pipeline that GoReleaser will run this
Signed-off-by: Alexander Soelberg Heidarsson <89837986+alex5517@users.noreply.github.com>
4 participants
No description provided.